Skillet cannot be enchanted

vectorwing / FarmersDelight

[Forge] A lightweight farming expansion for Minecraft.

MIT License

293 stars 174 forks source link

Skillet cannot be enchanted #938

Closed Inonedn closed 2 months ago

Inonedn commented 2 months ago

Minecraft version

1.21

Farmer's Delight version

Latest

Forge version

NeoForge 133

Description

Skillets can no longer be enchanted, when it should be able to receive the same enchantments as a sword

Steps to reproduce

N/A

Mod list

N/A

Logs

N/A

Minimal instance

[X] I have tested this on a minimal instance

Performance and shader mods

[X] I am using performance or shader mods

vectorwing commented 2 months ago

I'm unable to replicate this on a minimal instance. The Skillet can be used in an Enchanting Table:

vectorwing commented 2 months ago

That said, I am using an internal override to allow the Skillet to obtain sword enchantments. I haven't actually tagged it as enchantable the same way I did to knives, so I can take a look at that later.

vectorwing commented 2 months ago

It seems the issue is related to the Anvil, not the Enchanting Table. Please add these details when opening issues, as it confused me for a moment.

Indeed, Skillets cannot receive Enchanted Books. I'll fix it on 1.2.5 soon.

vectorwing commented 2 months ago

Fixed on commit 779c87f.