search

veda-consulting-company / uk.co.vedaconsulting.mailchimp

Other
22 stars 43 forks source link

Make webhook URL configurable #295

Open michaelmcandrew opened 6 years ago

michaelmcandrew commented 6 years ago

Problem: A CiviCRM instance is running on a private network with a Proxy that is set up (using CiviProxy) to handle necessary communication with the outside world. Webhooks that are automatically configured by this extension will not reach the CiviCRM instance.

Proposed solution: Add an option to the mailchimp settings form that allows the webhook URL to be specified so that when the form is submitted and the settings are create/refreshed it is set to an appropriate URL on the proxy.

Happy to submit a PR along these lines if this sounds like an acceptable approach to you.

veda-consulting commented 6 years ago

@michaelmcandrew sounds good to us, if you'd like to submit a PR would be great

michaelmcandrew commented 6 years ago

Hey there,

Actually, at the moment, the client is re-assessing how they want to link with mailchimp so this is on hold for the moment. Feel free to close and we can re-open if necessary.

FYI, we did something similar for the Sparkpost which you can see in this PR in case it is useful for anyone coming afterwards: https://github.com/cividesk/com.cividesk.email.sparkpost/pull/57