veda-consulting-company / uk.co.vedaconsulting.mailchimp

Other
22 stars 43 forks source link

Civi 5.x and PHP7 #305

Open ddoligalski opened 6 years ago

ddoligalski commented 6 years ago

Realizing that this extension is 4.7 compliant, I assume that it is 5.0 compliant as well. I suggest you update appropriately.

At the same time, has this extension been tested using PHP 7 (7.1 in particular)???

Thanks!

elisseck commented 6 years ago

In case it's helpful: I recently tested this extension (v 2.0.1) on a buildkit install with CiviCRM 5.1.2 and PHP 7.0.30 and it seemed to mostly work great with my test cases.

I say mostly because I had an issue installing the extension where it would not create the table civicrm_value_mailchimp_settings for some reason and i'm not sure why because the install xml looks fine to me. Clicking through the installer seemed to work but I couldn't sync without that table of course.

A quick

create table civicrm_value_mailchimp_settings (
id int NOT NULL AUTO_INCREMENT,
entity_id INT,
mc_list_id varchar(255),
mc_grouping_id varchar(255),
mc_group_id varchar(255),
is_mc_update_grouping BOOLEAN DEFAULT NULL,
PRIMARY KEY (id)
);

seemed to solve the DB errors I was getting and it all seems to work fine. I'm assuming if there hasn't been a lot of hoopla that the missing table is some sort of weird issue with my development env.

zkrebs commented 6 years ago

Has anyone else tested this extension on the current versions of CiviCRM and PHP 7?

elisseck commented 6 years ago

Just to chime in again - I just had another experience on a flavor of PHP 7.1 and CiviCRM 5.3.1 on an amazon server. Everything in their php.ini looks default (should default to '&') - but the http_build_query($data) in /CRM/Mailchimp/Api3.php was generating incorrect cURL calls by using '& amp;' as the separator instead of &. Needed to modify it to be http_build_query($data, "", "&") L302.

Everything else is working as far as I can tell.

zkrebs commented 6 years ago

Thank you. Mailchimp is also introducing "tags". Wonder if this extension could make use of that?

alexanderaeppli commented 5 years ago

Just wanted to ask if this is still a thing. I will try it out on an test environment anyway but offical support for 5.x would be much appreciated.

richgillin commented 5 years ago

5.4.0 not working Extension Upgrade Failed DB Error: no such field