search

veda-consulting-company / uk.co.vedaconsulting.mailchimp

Other
22 stars 43 forks source link

Fixes for stats, accuracy, speed #71

Closed Kajakaran closed 10 years ago

Kajakaran commented 10 years ago

Fixes: 1) Statistics after the pull has been completed 2) Increase the speed of the pull process by calling the part of the array on every queue task rather than whole array and this process has been changed to 'sync list' from 'sync contact' 3) Assign the mailchimp contact to default group even the mailchimp group information present but the mailchimp contact is not assigned to any group 4) Change the user friendly label to mailchimp navigation menu 5) Modify the query to cover all the properties(like is_primary, is_deleted) for matching contact 6) Update the contact's firstname/lastname for matching record if only firstname/lastname details are present for that contact in mailchimp 7) Unset the contact's type of individual for matching record while updating

deepak-srivastava commented 10 years ago
  1. reset pull-stats value to NULL than zero.
  2. updateContactDetails() shouldn't be responsible for stats calculation. May be just return indication of added/updated along with ID.
  3. Something for future - For bulk pull we need to remember how much we processed so if anything happens wrong we don't pull from beginning.

Lets discuss.