search

veda-consulting-company / uk.co.vedaconsulting.mosaico

Other
39 stars 75 forks source link

Check for existence of php imagik extension on install #51

Closed BailsBails closed 7 years ago

BailsBails commented 8 years ago

More of a this would be helpful rather than a bug.

Could you check for the existence of the php imagik extension upon install and halt and feedback if not found?

Cheers

bails

MegaphoneJon commented 8 years ago

I actually added this some time ago: https://github.com/veda-consulting/uk.co.vedaconsulting.mosaico/blob/master/mosaico.php#L250

I believe there's also a check when you load the page. The check I reference above will pop up as a "critical issue" on Civi 4.7. Are you using 4.6? 4.6 doesn't currently show warnings when extensions fail checks.

BailsBails commented 8 years ago

Hi Jon

Yes you guessed correctly this was on a 4.6. Glad to know its already in place for 4.7.

Thanks

Bails

deepak-srivastava commented 8 years ago

@BailsBails like @PalanteJon suggested, the check is there for page load.

But don't think it gets triggered on extension install. I'll leave this ticket open incase somebody wants to PR/help this.

MegaphoneJon commented 7 years ago

@deepak-srivastava I think you can close this because this check I wrote will handle this: https://github.com/veda-consulting/uk.co.vedaconsulting.mosaico/blob/2.x/mosaico.php#L170