search

veda-consulting-company / uk.co.vedaconsulting.mosaico

Other
39 stars 75 forks source link

Upgrade to intervention/image 3.0 #625

Open MegaphoneJon opened 11 months ago

MegaphoneJon commented 11 months ago

One of the most popular issues on this repo is support for animated GIFs, which our image manipulation library didn't support.

As of this morning, intervention/image 3.0 has been released, which supports animated GIFs.

We should try updating composer.json to pull in the latest versoin.

mattwire commented 7 months ago

@MegaphoneJon Happy to update if you can confirm it works?

MegaphoneJon commented 7 months ago

After I posted this I did some more research and we definitely will need to make some code changes.

There's also a PHP 8.1 requirement. So short of maintaining a 3.x and 4.x version of this extension, I don't know that there's a good short-term answer.

I no longer have clients interested in this, so I'll leave it to those with more vested interest to work on this.

MegaphoneJon commented 2 months ago

Just a thought - we could abstract away the differences between v2 and v3 of intervention/image. Then we could offer an animated GIF version of Mosaico.

Part of me thinks that's too much work and we should just wait for Civi's minimum PHP version to be 8.1, but 7.4 is still the most popular version, and every change in server requirements means losing users. So if someone is invested enough in this feature, that seems like the way to go.