veda-consulting-company / uk.co.vedaconsulting.mosaico

Other
39 stars 75 forks source link

Labels can't be read when they're long #630

Closed artfulrobot closed 8 months ago

artfulrobot commented 10 months ago

Anyone using Mosaico Message Templates will have long titles for the templates because they combine the template name and the message subject.

But others may reasonably have longer titles too.

This makes the select template display unworkable/unreadable:

image

Possibly related: https://github.com/veda-consulting-company/uk.co.vedaconsulting.mosaico/issues/526

artfulrobot commented 10 months ago

I have CSS changes to suggest but can't figure out how you compile your SASS?

$ npm install
up to date, audited 676 packages in 5s
...
$ gulp sass
[20:02:44] Working directory changed to .
AssertionError [ERR_ASSERTION]: Task function must be specified
    at Gulp.set [as _setTask] (./node_modules/undertaker/lib/set-task.js:10:3)
    at Gulp.task (./node_modules/undertaker/lib/task.js:1
3:8)
    at ./gulpfile.js:20:8
    at Object.<anonymous> (./gulpfile.js:84:2)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Module._load (node:internal/modules/cjs/loader:1023:12)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at require (node:internal/modules/helpers:176:18) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}
mattwire commented 10 months ago

@artfulrobot sass hasn't been compiled for 2 years so it's quite likely that the npm/gulp toolchain has broken in that regard :-(

artfulrobot commented 10 months ago

@mattwire yeah I fought it for an hour and got nowhere. Gulp.

But have made a PR the ol' fashioned way.

composerjk commented 8 months ago

In Mosaico 3.4, template labels seem worse. Looking at wpmaster.demo.civicrm.org and dmaster.demo.civicrm.org:

image

Originally noted on Mattermost with CiviCRM 5.70.1.

artfulrobot commented 8 months ago

@composerjk This looks odd. The change I brought moves labels to the side (so they can be longer) - see screenshot at: https://github.com/veda-consulting-company/uk.co.vedaconsulting.mosaico/pull/631

so if your labels are at the bottom then either that PR isn't included in 3.4 or something else is wrong.

What theme(s) are you using?

BeccaTregenna commented 8 months ago

@artfulrobot we see the same as @composerjk on 3.4 both with Radstock and The Island

artfulrobot commented 8 months ago

@composerjk @BeccaTregenna what CMS? And, never heard of radstock - got a link?

BeccaTregenna commented 8 months ago

Both on WordPress and I think Radstock comes with Civi Admin Utilities

composerjk commented 8 months ago

@artfulrobot That screenshot came from https://wpmaster.demo.civicrm.org

artfulrobot commented 8 months ago

I'll fix this

artfulrobot commented 8 months ago

Fixed, I believe, please see https://github.com/veda-consulting-company/uk.co.vedaconsulting.mosaico/pull/638

@BeccaTregenna I installed WordPress + installed the Admin Utils WP Plugin, but I couldn't see Radstock in the CiviCRM's theme options under Display Preferences? So I couldn't test that. EDIT: found it. See link above for screenshot

BeccaTregenna commented 8 months ago

Thank you @artfulrobot, it's much appreciated. I suspect I was wrong about Radstock, will check with @kurund

artfulrobot commented 8 months ago

@BeccaTregenna ah found it, just have to enable it a different way. All should be good - see the PR link for screenshots

artfulrobot commented 8 months ago

PR Link, https://github.com/veda-consulting-company/uk.co.vedaconsulting.mosaico/pull/638

composerjk commented 8 months ago

Cool, thanks! Look forward to it being merged with a new release.