veda-consulting / org.civicrm.sms.clickatell

Clickatell integration allows delivering short message service (SMS) messages through its Clickatell Gateway to mobile phone users.
1 stars 15 forks source link

Has Clickatell changed their authentication API? #13

Closed elcapo closed 6 years ago

elcapo commented 7 years ago

I'm trying to set up a new environment with a Clickatell integration and I've found that Clickatell is no longer using the api_id + user + password combination they where using before. They are now using an apiKey instead (https://twitter.com/Clickatell/status/854656741098782720). Does the extension need to be updated in order to work with this new API? Or maybe I'm missing something?

JohnFF commented 7 years ago

Clickatell has entirely changed their API - this extension no longer functions.

I have a locally working version that I achieved by:

  1. Removing the authentication concept.
  2. Updating the API URL.
  3. Adding the API Key to the URL.
veda-consulting commented 7 years ago

@JohnFF @elcapo we'll fix this version with the new APIs

veda-consulting commented 6 years ago

@elcapo @JohnFF this version works with the new keys If you put api_key= into the additional params then everything is fine?

JohnFF commented 6 years ago

Clickatell maintains two versions of the API. The old way still works through https, however this extension has moved exclusively to the new way. This requires all clients using the old method to update their Clickatell settings - but this extension doesn't tell them that. It just stops working.

veda-consulting commented 6 years ago

@JohnFF ok - maybe we can check the settings as part of the move i.e. we could fire a test from the settings page or something and include some instructions?

JohnFF commented 6 years ago

To be honest, I have a lot of ideas on how to improve this extension quite considerably. I've dropped you an email. Let's chat :)

jorich-2000 commented 6 years ago

I am not impressed with the lack of care being taken over maintaining compatibility . Clickatell have not retired the old api and there are many of us using this still. Just replacing code would be fine if it didn’t completely remove and break installations that are working. I have two clients who have had no sms for 6 months now!

JohnFF commented 6 years ago

Typically extension maintainers research these things and make sure that their extensions provide the needed features... it's currently 100% broken on all Civi46 installs, and on some Civi47 installs, depending on the API version (with the majority on the old version, which is broken).

JohnFF commented 6 years ago

@jorich-2000 if you want me to deliver something that works email me at john@civifirst.com

deepak-srivastava commented 6 years ago

Update: please checkout latest release v4.1 with backward compatibility.

veda-consulting commented 6 years ago

Thanks for your patience on this guys

I think its important to note this extension is maintained 100% voluntarily and assuming that we should be checking for the very strange practices that third parties take would be valid if we were financially invested in the relationships. As its voluntary and has zero test coverage we are stuck in the position where we have to find time to resolve issues, some of which could be very tricky.

@JohnFF it would be great if your offer to "deliver something that worked" was made as a PR back to the main extension, after all this is what community extensions are all about!

@jorich-2000 thanks for your debugging efforts on the other issue, we had been doing the same in parallel and came to the same conclusion. We've managed to keep it as a single extension as there is just the one change which is required to keep both sets of API keys working.