veda-consulting / org.civicrm.sms.clickatell

Clickatell integration allows delivering short message service (SMS) messages through its Clickatell Gateway to mobile phone users.
1 stars 15 forks source link

The API Link in the interface is overridden in the code. #14

Closed JohnFF closed 6 years ago

JohnFF commented 7 years ago

The API Link in the interface is overridden in the code, which is misleading for users.

veda-consulting commented 7 years ago

@JohnFF could you give us an example of what you mean?

JohnFF commented 7 years ago

Sure, look in the code: _apiURL is defined with a URL. But then it's never used! #Confusing. It does look like the link in the interface is used after all.

veda-consulting commented 6 years ago

@jyothi-shree21 can we remove the bit of code that John is referring to - the definition should still be there but the URL shouldn't be set. Please make sure there aren't any warning etc when you test the code in PHP etc.