veda-consulting / org.civicrm.sms.clickatell

Clickatell integration allows delivering short message service (SMS) messages through its Clickatell Gateway to mobile phone users.
1 stars 15 forks source link

php 8 fix for curl #32

Open MegaphoneJon opened 1 year ago

MegaphoneJon commented 1 year ago

Ih PHP 8.0+, curl_init() returns an object and not a resource, so this extension fails with a fatal error whenever you try to send an SMS.

This is a PHP-agnostic solution. See also https://php.watch/versions/8.0/resource-CurlHandle#is-resource

demeritcowboy commented 1 year ago

👍 I just hit this in another sms extension and then came here to see if it was fixed here, since the code was originally partly copied from here.

chaplincircle commented 1 year ago

The change to org_civicrm_sms_clickatell.php worked for me on version 4.1. Is it possible to merge and release a version? @deepak-srivastava and @veda-consulting Thanks

marcusjwilson commented 2 months ago

@deepak-srivastava and @veda-consulting

Could someone please merge this change and release a new version of the extension? It doesn't work on PHP 8.1 without this fix.