search

veda-consulting / uk.co.vedaconsulting.module.civicrmpostcodelookup

CiviCRM Postcode Lookup
Other
2 stars 9 forks source link

Always "trigger change" on county element #16

Closed y3kdaniel closed 7 years ago

y3kdaniel commented 7 years ago

15

veda-consulting commented 7 years ago

@y3kdaniel can you provide a bit more info on the issue and resolution? We'd love to include it if we can understand why its needed. Thanks

y3kdaniel commented 7 years ago

The full detail was posted in my initial issue report, with my resolution added as a comment, which can be found here: #15

y3kdaniel commented 7 years ago

But the basic version is, that without this patch, the module sets the form County value to null (or '') but unless the returned address includes a county it does not trigger the displayed County to update. Adding the trigger to a separate line outside of the if statement means that the displayed County will be updated either to show no county or the county returned in the lookup, if there is one returned. (CiviPostcode won't return a county as the PAF file does not include them)

mattwire commented 7 years ago

@veda-consulting This can now be closed, as it's included in #21

veda-consulting commented 7 years ago

closed, as it's included in #21