search

veda1234 / CAST-at-IIT

Contamination Assessment and Site-Management Tool
0 stars 0 forks source link

Liedl3D.py issue with calculating the "# Finding the appropriate starting value" #16

Open prabhasyadav opened 4 years ago

prabhasyadav commented 4 years ago

Hi @veda1234 @abiral95

Pls. update the liedl3D.py "# Finding the appropriate starting value" Code Lines (22-36). Extra "()" was found in ma_1 calculation. This does not affect the result of the model.

The new code should be: 

Cf = (g*Ct+Ca)/(g*Cd+Ca)

ma_1 = -1/(np.pi*(Th/W**2)*np.log(1-0.25*np.pi*(Cf)))   
ma_2 = -2/(np.pi**2*(Tv/M**2))*np.log(0.25*np.pi*(Cf))
ma_3 = 4/np.pi**2*(M**2/Tv)*np.log(4/(np.pi*Cf)) 

min_x0 = np.minimum(ma_1, ma_2)
ma_x0 = np.minimum(np.maximum(ma_2, ma_3), ma_1)

if ma_x0 == ma_3:
    x0 = max_x0
else:
    x0 = min_x0

Cheers

P