Closed tirkarthi closed 6 years ago
Thanks! I've cleaned up the tests and pushed them to master with this commit: https://github.com/vedang/clj_fdb/commit/c2e5695e08de6324b3ffb89e47c769fbf7782f43
The cleanup was as follows:
is
clause was malformed, the value key was outside of the clause.key
/value
to k
/v
to avoid clobbering the built-in clojure.core/key
fn.Thanks for the comments. I will keep them in mind with respect to my test suite too. I have some more tests that I will try porting as I find time.
https://github.com/tirkarthi/clj-foundationdb/blob/master/test/clj_foundationdb/core_test.clj
👍 That would be great!
Since I don't have access to the project I can't add this to Travis CI. I tested the config in my fork. Feel free to edit this PR if you have plans to use other CI.
Travis build : https://travis-ci.org/tirkarthi/clj_fdb/builds/375447446
Thanks.