vedang / pdf-tools

Emacs support library for PDF files.
https://pdftools.wiki
GNU General Public License v3.0
643 stars 90 forks source link

epdinfo is creating all files with the execute bit set #138

Closed znewman01 closed 2 years ago

znewman01 commented 2 years ago

See:

https://github.com/vedang/pdf-tools/blob/bb0b71f5bafd81d0b5647c4ec48fafa0bb6f6c21/server/epdfinfo.c#L357

Is there a reason? It's writing PNG files with +x to /var/tmp (on my Mac); executable files in temp directories are a little scary generally and my endpoint security scanner is raising alarm bells. Plus it doesn't seem like we need it.

vedang commented 2 years ago

It isn't necessary. Please submit a patch removing it, and I will merge it in (or wait for the end of this month, when I have set aside a weekend for working on pdf-tools