vedang / pdf-tools

Emacs support library for PDF files.
https://pdftools.wiki
GNU General Public License v3.0
643 stars 90 forks source link

Underline looks like strikethrough #180

Open sati-bodhi opened 1 year ago

sati-bodhi commented 1 year ago

Describe the bug Underline markup looks like strike-thorough

Steps to Reproduce the behaviour

  1. Open pdf file in pdf-view.
  2. Select region (highlight a word)
  3. pdf-annot-add-underline-markup-annotation

Result:

Screenshot from 2023-01-07 20-28-55

What is the expected behaviour? Underline should be closer to the bottom of the characters.

Desktop Please complete the following information:

Your pdf-tools install Please complete the following information:

Version 1.0.0

;;;; Org-pdftools
;; Run `pdftools-install` to initialize.

(use-package! org-pdftools
  :config
  (setq
   org-pdftools-root-dir #'~/Zotero/storage
   org-pdftools-search-string-separator "??")
  (with-eval-after-load 'org
    (org-link-set-parameters "pdftools"
                             :follow #'org-pdftools-open
                             :complete #'org-pdftools-complete-link
                             :store #'org-pdftools-store-link
                             :export #'org-pdftools-export)
    (add-hook 'org-store-link-functions 'org-pdftools-store-link))
  (pdf-loader-install)

(add-to-list 'pdf-annot-list-listed-types 'square)
  )

Additional context

tongjie-chen commented 1 year ago

Does it show the same on Evince? When you select the line, is the selection's bottom border at the current underline location?

If so, that's the PDF's text layer's problem.

sati-bodhi commented 1 year ago

Screenshot from 2023-01-12 10-33-56

I've tested out on Okular and Evince. The underline looks normal.