search

vedang / pdf-tools

Emacs support library for PDF files.
https://pdftools.wiki
GNU General Public License v3.0
641 stars 90 forks source link

Combine the new inverted colors feature with the themed minor mode #186

Open vedang opened 1 year ago

vedang commented 1 year ago

Discussed in https://github.com/vedang/pdf-tools/discussions/185

Originally posted by **skyler544** January 21, 2023 Nice work on the inverted color view; it's a great step in the direction of having consistently readable dark-mode for PDFs in Emacs. If I understand what I'm seeing from the source code however, it seems like it's not possible to both keep hue and use the colors from the active theme? It would be very nice to have that feature; it's one of the few reasons why I still fall back to viewing PDFs in Zathura.
bataak commented 1 year ago

Hi

Maybe for some people it's good choice to use it with the inverted color, but for some people like me, it's not a great option. I prefer previous one. I use solarized theme.

vedang commented 1 year ago

@bataak : Just set pdf-view-midnight-invert to nil in your .emacs.d config and the behaviour will remain what it previously was always.

bataak commented 1 year ago

I appreciate it.