search

vedang / pdf-tools

Emacs support library for PDF files.
https://pdftools.wiki
GNU General Public License v3.0
619 stars 90 forks source link

Add OpenSUSE to server/autobuild #96

Open vedang opened 2 years ago

vedang commented 2 years ago

Copying my comment from #92 for @Pi-Cla

Hello @Pi-Cla !

I've merged the change in, but since you are an OpenSUSE user, can you please create one more PR? Please also modify the server/autobuild file with instructions on installing the relevant packages for OpenSUSE. Here are the steps you need to follow (Search for os_gentoo or os_debian in the file. The functions associated with these Operating Systems are simple to copy and change, so you can use these as reference.):

Add a call under handle-options, which is a cond-loop to pick up the correct Operating System to execute on. Add handling for the --os argument in os_argument for opensuse, so that the appropriate function can be called to install pre-requisites. Create a os_suse function. This function checks if we are running on OpenSUSE. If we are not, it returns and does nothing. However, if we are running on OpenSUSE, it sets up PKGCMD, PKGARGS and PACKAGES so that the appropriate package manager zypper can install the dependencies as part of the rest of the script. The idea here is to make the server/autobuild file the single place from which installation can happen on any Operating System. This makes building pdf-tools dead simple via the Makefile.

Thaodan commented 1 year ago

Is was just thinking of doing this using: https://openbuildservice.org/help/manuals/obs-user-guide/cha.obs.scm_ci_workflow_integration.html

Is it ok to host the rpm in here?

vedang commented 1 year ago

At the moment, I do not have any plans to support building distribution packages from this repo. This ticket tracks simplifying how to build pdf-tools from the source. (More information here: https://pdftools.wiki/A34704B9)

Other people have built packages for operating systems, which are mentioned in the README here: https://pdftools.wiki/fb5cef15 . If you do end up creating / maintaining an RPM package, do update the relevant section in the README.org file.

Thaodan commented 1 year ago

At the moment, I do not have any plans to support building distribution packages from this repo. This ticket tracks simplifying how to build pdf-tools from the source. (More information here: https://pdftools.wiki/A34704B9)

I understand. This step would help to build release packages for any distribution on the obs for release builds or even for PRs.

My plan was to save the spec file in this repository with an obs workflow so that the package will be rebuild whenever a new release is tag.

If any other build recipes will go this repository they can build on the obs the same way.

Other people have built packages for operating systems, which are mentioned in the README here: https://pdftools.wiki/fb5cef15 . If you do end up creating / maintaining an RPM package, do update the relevant section in the README.org file.

Sure that was the idea.

vedang commented 1 year ago

Honestly, I would love it if you can contribute the work and set it up such that the relevant assets are generated.

However, I'm worried that this will be another vector of maintenance that I'll have to manage.

I browsed the draft PR and the OBS website. I'm curious to see how this turns out. If you continue working on it, please share back / update the PR!

On Sun, Jan 22, 2023, 10:36 AM Björn Bidar @.***> wrote:

At the moment, I do not have any plans to support building distribution packages from this repo. This ticket tracks simplifying how to build pdf-tools from the source. (More information here: https://pdftools.wiki/A34704B9)

I understand. This step would help to build release packages for any distribution on the obs for release builds or even for PRs.

My plan was to save the spec file in this repository with an obs workflow so that the package will be rebuild whenever a new release is tag.

If any other build recipes will go this repository they can build on the obs the same way.

Other people have built packages for operating systems, which are mentioned in the README here: https://pdftools.wiki/fb5cef15 . If you do end up creating / maintaining an RPM package, do update the relevant section in the README.org file.

Sure that was the idea.

— Reply to this email directly, view it on GitHub https://github.com/vedang/pdf-tools/issues/96#issuecomment-1399406084, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUUHX7VU5OG67MSTWWCGDWTS57FANCNFSM5UKIQLBQ . You are receiving this because you authored the thread.Message ID: @.***>