vedangj044 / Frisson

Android app to read reports of UFO sightings

5 stars 2 forks source link

Closed spacemonkey1101 closed 3 years ago

spacemonkey1101 commented 3 years ago

Related Issue

-added view model and page adapter -solves #7

I will commit further once admin confirms that I'm heading in the right direction

vedangj044 commented 3 years ago

Hey, @spacemonkey1101 Great work, I checked it and it works well. I can see the fetched data. I have 3 things to say

Please change the Gradle version to 4.1.1 because difference in gradle version causes avoidable build errors,
Please change the pageSize in MainViewModel to 50 val listData = Pager(PagingConfig(pageSize = 50)) {
We have a different issue #15 for adding data binding to the list items, so once you make the above 2 changes I would merge this PR.

Thanks for the contribution

spacemonkey1101 commented 3 years ago

Hello I have made the requested updates. -Im getting this error when my gradle build version is 4.1.1 "This version of the Android Support plugin for IntelliJ IDEA (or Android Studio) cannot open this project, please retry with version 4.1 or newer." which I solved using this stack overflow answer: https://stackoverflow.com/questions/62678785/android-support-plugin-for-intellij-idea-or-android-studio-cannot-open-this-pr

-also can you share the link to this projects discussion channel

vedangj044 commented 3 years ago

https://gitter.im/frisson-communication/community?utm_source=share-link&utm_medium=link&utm_campaign=share-link this is the Gitter channel, you are already in the channel. Anyways, Thanks for the changes, it works good now.