vedangj044 / Frisson

Android app to read reports of UFO sightings
5 stars 2 forks source link

arrange code in MVVM pattern #30

Closed spacemonkey1101 closed 3 years ago

spacemonkey1101 commented 3 years ago

I'm submitting a

The code does not follow any architecture but introducing one would be helpful

vedangj044 commented 3 years ago

Well, I beg to differ here, we are following 100% MVVM architecture, up till now. The business logic, network request are maintained separately, We have maintained a repository class for the paging request. Then we have maintained ViewModel to hold the data, which is then sent to the view.

What you are saying probably is there should be separate packages for each of the file, and I agree with you, you can create separate packages for each.