added Numbers API - Githubissues

vedangj044 / just-calling-random-api

React app to call various APIs. A place for new contributors to learn how to consume their APIs and contribute to open-source. Part of Hacktoberfest.

https://vedangj044.github.io/just-calling-random-api/

MIT License

25 stars 55 forks source link

added Numbers API #58

Closed deekay1712 closed 3 years ago

deekay1712 commented 3 years ago

Description

Added NumbersApi to get Historical Fact of the day.

Checklist

[x] API used in this PR was not used in just-calling-random-api before.
[x] API used in this PR is Public or I have permission to use it.
[x] My contribution is working.
[x] My contribution doesn't expose any API keys.
[x] My changes don't generate any new warnings.
[x] My changes don't affect any work done by other developers.

vedangj044 commented 3 years ago

Hey, Thanks for the PR. There are some merge conflicts, that's okay. Kindly sync your fork ( https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/syncing-a-fork ) and rebase the numbers-api branch. ( https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase )