search

vedantchandra / starwave

modeling resolved stellar populations with bayesian inference
MIT License
2 stars 2 forks source link

Include sigma av as another parameter for starwave to use. #25

Open joycelin1123 opened 11 months ago

joycelin1123 commented 11 months ago

Add in sig_av as another parameter. In starwave.py, get_cmd and sample_cmd have been updated to include this change. In parameters.py, make_params has been updated with an extra line to include this.

mgennaro commented 11 months ago

It would seem that this PR also includes the export of other quantities (sdict) from the get_cmd method. Please clean that up and submit a separate PR for that, so it's documented. Also, please check what happens if one sets the sigma_av to 0. That will be a typical use case (i.e. no differential reddening) and it would be nice to be able to fallback to the original behavior of no sigma_av. If sigma_av == 0 causes problems with the normal distribution being degenerate/undefined, then please set the default value to something small (eg 1e-5) which is effectively zero, but first check that such small number indeed does not cause problems with the normal distribution.