Fix: ScrollController not attaching to the PaginateFirestore widget

vedartm / paginate_firestore

A flutter package to simplify pagination with firestore data 🗃

https://pub.dev/packages/paginate_firestore

MIT License

113 stars 138 forks source link

Fix: ScrollController not attaching to the PaginateFirestore widget #68

Closed jslattery26 closed 3 years ago

jslattery26 commented 3 years ago

The scrollController parameter was never passed to the buildListView > CustomScrollView controller property

vedartm commented 3 years ago

Hi @jslattery26! Thanks for making this PR. But I have already fixed it in the latest version 1.0.0-nullsafety.1.

jslattery26 commented 3 years ago

Still not fixed in 1.0.0-nullsafety.1.

Widget _buildListView(PaginationLoaded loadedState) {    
var listView = CustomScrollView(      
reverse: widget.reverse,      
shrinkWrap: widget.shrinkWrap,      
scrollDirection: widget.scrollDirection,      
physics: widget.physics, 
slivers: 
...

Controller still not being set in _buildListView.

vedartm commented 3 years ago

Sorry my bad @jslattery26