search

vedb / pupil_recording_interface

A pythonic interface for the Pupil Core system
https://vedb.github.io/pupil_recording_interface
GNU General Public License v3.0
1 stars 0 forks source link

Make sure the eye camera parameters are set to optimal values #75

Closed KamranBinaee closed 3 years ago

KamranBinaee commented 3 years ago

The auto-exposure seems not to be active for the eye cameras making the frames washed out even under indoor lighting conditions. Also other parameters such as sharpness, brightness, etc.

phausamann commented 3 years ago

This can be set via VideoDeviceUVC constructor/config args: exposure_mode="auto" (default is "manual", despite what the docstring says, whoops) and the rest via controls=dict(...). Available controls and their current values can be queried with VideoDeviceUVC.controls.

KamranBinaee commented 3 years ago

Great! Thanks @phausamann Let's, for now, make the exposure_mode="auto" as the default setting. Checking all the data collected now, even for indoor lighting the images are too washed out. I'll also double-check this by changing the parameters using pupil_capture and come up with a dictionary of default values for other parameters.

phausamann commented 3 years ago

I set the default to manual because that's the default in the pupil source code, but I guess we could change that to auto. Nevertheless, the config should explicitly specify the exposure mode, just in case.

Also, it seems that this doesn't actually enable auto-exposure on the cameras (the 200 Hz cams don't support auto-exposure apparenty, see https://github.com/pupil-labs/pupil/issues/1156), but rather calculate the manual exposure time based on the previous frame.

phausamann commented 3 years ago

For the other parameters, I'd recommend setting these via the config (i.e. in ved-capture).

phausamann commented 3 years ago

Closed in favor of downstream issue.