search

vedb / pupil_recording_interface

A pythonic interface for the Pupil Core system
https://vedb.github.io/pupil_recording_interface
GNU General Public License v3.0
1 stars 0 forks source link

Update Circle Detector and Validation Classes #77

Closed KamranBinaee closed 3 years ago

KamranBinaee commented 3 years ago

Make sure you have:

phausamann commented 3 years ago

Not sure about the validate_flir example. It seems like a lot of duplication compared with the validate example and it works only for a specific camera type. I'd probably prefer something like a stream_flir example that just shows how to set up streaming for a FLIR camera.

KamranBinaee commented 3 years ago

Ok, Thanks! @phausamann I just pushed the changes. Removed the validate_flir.py and made the necessary changes to the validate.py Added the check if the file_name is None Added the scale and max_resolution to the display class. Ideally, maybe we'd want to specify this in the config for each stream. i.e. now the eye videos (400x400) are as large as the world video, maybe visually not very pleasant? I guess!

phausamann commented 3 years ago

Thanks @KamranBinaee, I've modified the VideoDisplay a little bit (max_width instead of max_resolution and scale). We should probably add a sensible default in the config downstream.