vedb / ved-capture

Visual Experience Data Capture
1 stars 0 forks source link

Additional features for vedc validate #33

Open phausamann opened 4 years ago

KamranBinaee commented 4 years ago

I added the first commit to the validate_command branch just to start the conversation on how we'd want this to be implemented. Some topics to discuss and implementation questions that I was not sure:

KamranBinaee commented 4 years ago

Testing whether I can ping users here to make sure you guys can see the comments. @phausamann @marklescroart

phausamann commented 4 years ago

@marklescroart @KamranBinaee

My takes on this are:

  1. Could be nice to generate a "validation report" that prominently highlights when the calibration failed.
  2. I believe the experimenter needs to visually inspect the validation results anyway, so I don't think audio feedback is necessary.
  3. Yes, you need to add the matplotlib dependency to environment.devenv.yml and pin it to a reasonable version (whatever you have currently installed in your env should be fine).
  4. I'm still not 100% clear about the exact validation procedure. Do we want to record the streams during the validation? If yes, we can just save the report to the recording folder.
phausamann commented 4 years ago

One important step is also to check that the actual FPS for each stream match the configuration.

phausamann commented 4 years ago

Copied from #18:

We should probably add a recording verification, either as a step at the end of the recording, or as a separate command that checks these things for all streams, e.g.:

  • Matching timebases
  • Similar start and end times
  • Frame rates matching specification in config file
  • No frame drops or jitter in timestamps