Fix AS504x DIAG and MAGN addresses.

vedderb / bldc

The VESC motor control firmware

2.16k stars 1.35k forks source link

Fix AS504x DIAG and MAGN addresses. #462

Open raidoz opened 2 years ago

raidoz commented 2 years ago

According to AS5047D datasheet (https://ams.com/documents/20143/36005/AS5047D_DS000394_2-00.pdf), DIAAGC is 0x3FFC and MAG is 0x3FFD, in enc_as504x.c they are, however, incremented by one, reading back MAG for DIAG and ANGLEUNC for MAG.

Teslafly commented 1 year ago

Just checking, was this tested? If so using what setup?

vedderb commented 1 year ago

I currently have no way to test this as I didn't add miso to any of my as5047 test boards. It would be good if someone who has been using the as504x with miso can give some feedback on this.

Teslafly commented 1 year ago

Should this be included the the v6.0 firmware release?