search

vedderb / bldc

The VESC motor control firmware
2.16k stars 1.35k forks source link

Your file directory is too messy #496

Closed zouzhe1 closed 2 years ago

zouzhe1 commented 2 years ago

A project should have a clear file structure. You all put a pile of source files under the root directory, which is very unreadable

Teslafly commented 2 years ago

While this issue could probably have been put more eloquently, I do agree. It would be nice if the amount of base files fit on one page of a file tree sidebar.

I think you could get there by placing all root c files in a src folder. Maybe moving motor controller files into their own folder as well (mcpwm, foc_math, mc_interface, virtual motor) Doing that would also provide a place to seperate out hardware abstraction in the future.

Ncerzzk commented 2 years ago

you are so rude.

Teslafly commented 2 years ago

This has been fixed somewhat. Several functional blocks have been moved into their own folders and there are now many less files to wade through in the main directory.

Without a larger restructuring, this is about as good as it will get and this issue should probably be closed.