search

vedderb / bldc

The VESC motor control firmware
2.14k stars 1.34k forks source link

Safety critical bug: throttle runaway event/ cruise control #527

Closed AkbarRamzan closed 1 year ago

AkbarRamzan commented 1 year ago

It is possible for cruise control to become enabled randomly. I am not sure what’s causing it but I believe it may be related to the uart app. There needs to be a way to disable cruise control interpretation from the app! Please add more details if you know about the issue. For now disabling the uart app seems to work.

vedderb commented 1 year ago

I have not seen this myself. How do I reproduce this problem?

AkbarRamzan commented 1 year ago

It's hard to reproduce but I think this is what is happening: I have UART display connected (not supported by VESC) The display sends packets which just so happens to correlate to enable cruise control wheel therefore stays at constant speed until brake is pressed In the UART app, I propose a way to disable cruise control setting

In this scenario it was my mistake, no need to enable uart app when using uart in lisp but other people have also been having this issue.

nitrousnrg commented 1 year ago

Yes, it was your mistake at hardware level, something that an end user should normally not have access to.

Having said so, I did the same mistake a few years ago in a high power ebike so having the option to simply disable cruise control would be nice.

AkbarRamzan commented 1 year ago

This can actually happen when there is nothing connected to UART port, as long as the UART app is enabled. Maybe from noise? Idk

AkbarRamzan commented 1 year ago

Afzal said: "I think when uart app is enabled, servo will act as cruise control button (might depend on the board), and probably the signal on servo pin is causing the issue"

nitrousnrg commented 1 year ago

Issue fixed in 35d2dfcff2ee1dbcb0ea23c0e52cf32a686317fd You can disable cruise control now.