search

vedderb / bldc

The VESC motor control firmware
2.08k stars 1.31k forks source link

New hwconf files: ADV200+500 and Thor300 #736

Open surfdado opened 2 days ago

surfdado commented 2 days ago

Floatwheel ADV200 and ADV500 Fungineers Thor300

REMOVED >> Also added a generic buzzer on the servo port in a non-intrusive way. Only enabled if SERVO_BUZZER is defined in the hw header. <<

Thor uses it to give feedback when pressing the momentary button to power off the board.

vedderb commented 2 days ago

I don't like the buzzer thing, it adds files, functions, names and noise for just toggling a pin at boot on some hardware. Also, many buzzers require that you actually PWM them.

I would suggest the following:

bild

Replace this line with a macro HW_BOOT_DELAY() that is defined to be chThdSleepMilliseconds(500) by default in hw.h. Then hwconfigs can override that define and used it to beep a buzzer, flash LEDs etc.

Regarding this change, what are you trying to achieve by removing it? Most apps and other threads should already be up and running before this sleep finishes. It only delays the boot ready CAN-frame. bild

surfdado commented 1 day ago

your concerns should all be addressed now