search

vedderb / nrf51_vesc

BLE-UART bridge for the VESC with packet handling and VESC Tool compatibility
56 stars 35 forks source link

Tack on last two bytes of MAC Address to ble gap device name #9

Closed Relys closed 4 days ago

Relys commented 4 days ago

I was tired of seeing all the VESC BLE UART gap device names being advertised, so I added a two byte UUID (last two of MAC address). Personally I feel like is easier for a user to remember (instead of reading the full mac address where their brain had to parse the 4 other bytes beforehand).

vedderb commented 4 days ago

I don't have any NRF51 left so I can't test this at the moment, but it looks good to me. Let me know if there are any problems.

Relys commented 4 days ago

I don't have any NRF51 left so I can't test this at the moment, but it looks good to me. Let me know if there are any problems.

Haven't had any problems what-so-ever. :) Thanks, I can also port to NRF52 but I don't have one to test haha. I guess NRF52 is less important because you can set custom name. I even tried to use flash memory driver for NRF51 to implement name change but couldn't get it working in a reasonable time frame. XD