search

veden / Rampant

Factorio Mod - Basic AI augmentation using potential fields
GNU General Public License v3.0
58 stars 22 forks source link

1.2.0 crash after a dozen of nests purged #57

Closed garrotte13 closed 2 years ago

garrotte13 commented 2 years ago

After working around problem #55 it gave a critical error in about half an hour of play with a little different stack, but looks like because of the same new feature (death mutations). I'm using that fixed gamesave with evo 79%, but will it happen with fresh new map created after some time?

Error while running event Rampant::on_entity_died (ID 4)
__Rampant__/control.lua:499: attempt to index field 'damagedBy' (a nil value)
stack traceback:
    __Rampant__/control.lua:499: in function <__Rampant__/control.lua:469>
garrotte13 commented 2 years ago

May be my request will be too selfish, but can we have an option to completely turn off Death mutations code? (setting max mutations per faction to 0 doesn't make it). Other new features of 1.2.0 are too sweet to return to 1.1.1.

veden commented 2 years ago

Can you describe why you don't want the death mutations and are you expecting the regional bases to change at all still? Setting the mutations to zero should work, what are you seeing?

There is a deeper problem around bases being recycled before all the chunks under a bases control have been destroyed.

garrotte13 commented 2 years ago

just because this code leads to unexpected crashes and game over after a few hours of base building. The feature is very good and fun.

garrotte13 commented 2 years ago

But from other point of view I played about 6 hours of new game, destroyed 21 spawners and didn't get this issue. Does it mean, that there must be a big map opened with a mass of spawners to get this issue (like in my old gamesave with 79% evo) - only in such situation script won't be in time processing all chunks?

veden commented 2 years ago

It comes down to chance. In the version on github this issue hasn't been fixed.

veden commented 2 years ago

this should be resolved on the master branch now

garrotte13 commented 2 years ago

Yes, looks like it is ok now.