vedmack / yadcf

Yet Another DataTables Column Filter (yadcf)
http://yadcf-showcase.appspot.com/
MIT License
732 stars 284 forks source link

Reset button with icon instead of text not working for range filters #543

Closed misanek closed 5 years ago

misanek commented 5 years ago

Hi, found bug, here is a jsFiddle with example: http://jsfiddle.net/fp2q4bex/2/

for text filters it works fine, but when you click on a icon and not on the button in range filters it doesn't work.

vedmack commented 5 years ago

Hhhhh @misanek and @konuch you both work at the same place? always giving 👍 to each other filter_reset_button_text was meant for plain text only, so that not a bug but rather a feature, but that doesn't mean that I wont add support for it 😜

konuch commented 5 years ago

Hey Daniel, thanks, it will be really appreciated. And yes, you've guessed it, we're colleagues :)

vedmack commented 5 years ago

fixed by @misanek in PR https://github.com/vedmack/yadcf/pull/544