search

vedmack / yadcf

Yet Another DataTables Column Filter (yadcf)
http://yadcf-showcase.appspot.com/
MIT License
732 stars 284 forks source link

PR for #566 and #567 #569

Closed misanek closed 5 years ago

misanek commented 5 years ago

jsfiddle: http://jsfiddle.net/t8y1egz7/ - client side server side tested locally

please check , since it is slightly bigger PR

vedmack commented 5 years ago

Ohhh, a really big one here 👍 I don't mind with the null feature, but IMO having "null" in you UI is really bad idea unless your table is for technical users only (even then I bet people prefer not to bump into nulls in their browser) It looks like some error, you better re consider showing null. Please show the [ ] checkbox in the same side (right or left) for all filters, otherwise the behavior is confusing, user should know where to expect those check box/es to appear.

and once again thanks for the PR

misanek commented 5 years ago

@vedmack Thanks for feedback, the check-boxes appear on the correct side, they are set with checkbox_position_after: true/false parameter, and for sake of an example, they ware set differently for different columns ( example comes from my testing page, where I wanted to verify, that the reset all button resets checkboxes as well , and on the both sides ).

konuch commented 5 years ago

Hey @vedmack , unfortunately, our tool is indeed used by technical users, they use it to set values into a configuration DB. Other systems that rely on this configuration, behave differently when we set NULL value, or 'NULL' string value for a given attribute. The users know this, and they want to also be able to filter by NULL values for text filters/range filters for server side tables. Thanks for taking the effort to review our contributions and also for your comments. 👍

vedmack commented 5 years ago

closing since @misanek sent PR https://github.com/vedmack/yadcf/pull/570