vedmack / yadcf

Yet Another DataTables Column Filter (yadcf)
http://yadcf-showcase.appspot.com/
MIT License
732 stars 284 forks source link

Can't show filter inside a column with Responsive extension #67

Closed cmjacques closed 10 years ago

cmjacques commented 10 years ago

Hi there,

Really love your work. Your plugin does exactly what I was hoping for (and more).

I'm using the Responsive extension and have noticed that when the extension hides columns yadcf displays a warning in the console:

Yadcf warning: Can't show filter inside a column N#5 for a hidden one (place it outside using filter_container_id)

It would be great if the plugin detected the Responsive extension ('responsive' or 'collapsed' class on the table) and didn't throw the warning.

Cheers

vedmack commented 10 years ago

Hi, Thanks, I just checked yadcf with Responsive extension, and it works just fine, I mean whenever the columns are removed from table and placed into the "expandable area" the filters are removed too, and whenever the columns are back to be a normal columns again - the filters are back to their original place, what behavior did you expect?

I updated the showcase page with a responsive datatable example (see the second table)

https://dl.dropboxusercontent.com/u/55621125/yadcf/war/DOM_Ajax_Multiple_1.10.html

b.t.w you should use the latest version of yadcf

Daniel.

cmjacques commented 10 years ago

Hi Daniel,

I should have been clearer sorry. yadcf works fine with the Responsive extension. I was just hoping the warning message could be suppressed. Not a big deal at all!

I'll give the latest version (0.8.3b1) a go now.

Thanks and keep up the great work, Chris

vedmack commented 10 years ago

I removed it in the 0.8.3.beta.1 because its really unnecessary.