search

vedmack / yadcf

Yet Another DataTables Column Filter (yadcf)
http://yadcf-showcase.appspot.com/
MIT License
732 stars 285 forks source link

TypeError: oTable.fnSettings is not a function #680

Open VictorioBerra opened 3 months ago

VictorioBerra commented 3 months ago

Does YADCF support DataTables 2.0? fnSettings get dropped?

vedmack commented 3 months ago

haven't checked compatibility with the 2.0, please share a working test page (jsfiddle / etc) so I check it out

VictorioBerra commented 3 months ago

@vedmack https://jsfiddle.net/425gmakb/1/

Your CSS is in the "CSS" tab, your JS is in the "JS" tab. At the very bottom is the sample code from your "DOM source" example.

VictorioBerra commented 3 months ago

@vedmack Any thoughts on this?

The error is being thrown here: https://github.com/vedmack/yadcf/blob/master/src/jquery.dataTables.yadcf.js#L5269

Should this be this.api().settings().tables()[0].sTableId?

fnSettings is being accessed in a LOT of places. Does this all need to be changed to access settings via the public API somehow now?

VictorioBerra commented 3 months ago

Here is a self-contained index.html, jsfiddle just chokes out when I try and work in it with all that code. Hope this helps.

https://gist.github.com/VictorioBerra/6b2fd02957ad430a5ce91f95087b4b4c

vedmack commented 2 months ago

Hi @VictorioBerra, I will check this out

VictorioBerra commented 2 months ago

@vedmack Any luck?

louking commented 2 months ago

FWIW, all the legacy API has been removed (functions starting with fn). See https://www.datatables.net/blog/2024/datatables-2#Removed and https://www.datatables.net/upgrade/2#Removed for details.

vedmack commented 1 month ago

@VictorioBerra @louking I just pushed the 2.0.1.beta.1 although I did a lot of API adoptions to the new DT 2, there is still a lot of work to be done, so it might take some time, feel free to check it out and provide feedback https://github.com/vedmack/yadcf/blob/master/2.0/jquery.dataTables.yadcf-2.0.js I did noticed that there seems to be some issue with jquery UI filter plugins that I need to resolve

VictorioBerra commented 1 month ago

@vedmack thank you!! I am looking forward to it!

vedmack commented 1 month ago

@VictorioBerra check out yadcf 2.0.1.beta.4 on https://jsfiddle.net/vedmack/8bur71tk/ test page feel free to provide additional test cases note that you should use the yadcf.init to init the filters

vedmack commented 1 month ago

new showcase page https://yadcf.web.app