search

vedmalex / mws-sdk

Complete Amazon marketplace web services client for Node.js.
MIT License
27 stars 29 forks source link

Add more tests #10

Closed pulkitsinghal closed 8 years ago

pulkitsinghal commented 8 years ago

I began my attempt to understand this library by using tests. During this brief effort, I was able to abstract the setup into env.sh file and use a promises library to demo usage of one product api endpoint.

I want to contribute this back in hopes that it will help others and perhaps even lead to more test related contributions.

For example, one key behavior that I learned about this library was that it does not return an ErrorResponse from amazon via reject! It is debatable whether that is desirable or not ... but it definitely becomes easier to spot and accept as the current behaviour when tests fail.

pulkitsinghal commented 8 years ago

Wow, thanks!

vedmalex commented 8 years ago

it is in npm repo! thank you for your contibution !