veebch / hometime

A physical progress bar based on Google Calendar events
GNU General Public License v3.0
45 stars 6 forks source link

Improvement for WIFI credentials #7

Closed danionescu0 closed 1 year ago

danionescu0 commented 1 year ago

I want to to an improvement with setting up WIFI credentials If a pushbutton is pressed the board could enter in AP mode and offer a simple page where WIFI credentials are set, then getback on normal mode

What do you think about it? I could try writing the code :)

veebch commented 1 year ago

Good idea.

There are things that will automatically switch to AP mode if no wifi details are in there:

https://github.com/simonprickett/phewap

You could use that as-is, or add a button to trigger the AP. Either way, good idea.

danionescu0 commented 1 year ago

Ok cool. Please keep the ticket open and i'll work on it when i have free time.

danionescu0 commented 1 year ago

Ok, so i've tested the repo you suggested 192.168.1.110, it works fine. I could use some of the code there I propose using a pushbutton, because with this alternative you can always reconfigure the wifi by pressing the button. But the alternative from the https://github.com/simonprickett/phewap simpler, no pushbutton needed :). Just tell me what you prefer

veebch commented 1 year ago

It's a question I've thought about, phewap is clever in that the AP reappears any time the wifi credentials stop working (or the wifi it is used to is no longer there)

The people making a progress bar are all savvy enough to get to the files on the pico if they need to, so I think no button, just the phewap code.

EDIT: If you want to add code for a button and the callback stuff in such a way that the button is optional and the code works when it isn't there, that would be the best of both worlds.

danionescu0 commented 1 year ago

I've forked the repository and made the changes and tested locally the setup (without google calendar integration), seems to work, before submitting the PR if you like to take a look and they are here : https://github.com/danionescu0/hometime/tree/issue-7-wificonfig

veebch commented 1 year ago

I;ve skimmed through it and it looks good, I'll do a quick test with google calendar and merge it.

danionescu0 commented 1 year ago

Ok thanks for accepting my update! I have an unresolved issue though, i've used Thonny editor to install the "phew" library used for the web server. Should i update the documentation to add details on how to do that? or do you suggest an alternative ?

veebch commented 1 year ago

I've added phew to the repo....I'll update the readme as soon as I get a chance

danionescu0 commented 1 year ago

Ok great, i'll close this issue then