search

veechs / Postal-Returned

Mail addon for Vanilla WoW 1.12 (including Turtle WoW). Open all unread mail, send multiple items at once, and more.
1 stars 0 forks source link

TOC file does not work with Turtle WoW Launcher #2

Closed dired closed 2 days ago

dired commented 5 days ago

Hello!

The toc-file has a space instead of a "-", which makes the addon not load.

When manually setting the "-", that leads to addon managers (from the new launcher or gitaddonmanager) resetting that change on update.

Cheers and thanks in advance

veechs commented 5 days ago

Thanks for the report! Just so we’re on the same page, the expectation (as documented) is that the folder containing the addon will be given the same name as the TOC file, not the other way around. So 📄Postal Returned.toc ⇒ 📁Postal Returned (with a space).

The need to change the dash to a space is admittedly different from most other addons, where the only step for manual installation is to remove the branch name. But since I (and many others) have successfully used GitAddonsManager with the repository as-is, it never seemed to be a big problem.

I will test it with the Turtle launcher when I get a chance in case they’re doing something strange.

dired commented 4 days ago

Thank you very much for the clarification, that was very understandable and new to me. Interesting that the GitAddonsManager is (assumingly) able to detect the right name as opposed to the turtle launcher. I just came back to the game after a year and it coincided with the launcher-update, after I saw that I ditched gitaddonsmanager which I had already played around with.

So my initial phrasing was not correct, I did not try with gitaddonsmanager (I just assumed they would behave the same, sorry!).

I just tried again with the turtle addons-manager by deleting the folder and letting it recreate (a few times) and verified: the automatically created Folder is 📁Postal-Returned (with a minus).

I tried with both inputting the git url and the repository website url (without the .git).

Thanks for checking it out!

veechs commented 3 days ago

Finally got to do some testing with the Turtle WoW Launcher and you're right - it doesn't rename the addon folder to match the TOC like GitAddonsManager, so I added a new TOC file in fb6bc2361c2e947100bf62ff11e17f7603155462. This also led me to uncover a Launcher bug that I've reported and worked around in c8e4bfd7135df61a2a545ca10e708dc610351953.

If you update to the latest version, I believe everything should work correctly with the TW Launcher. Thanks again for taking the time to report the issue!