search

veecle / tricore-probe

Just like probe-run but targeting the Tricore-Architecture
Apache License 2.0
20 stars 5 forks source link

Refactor all calls into MCD libray #13

Closed therealfrauholle closed 3 months ago

therealfrauholle commented 7 months ago

In rust_mcd::raw we started to build strong(er) typed variants of the native, unsafe MCD functions. We want to refactor all calls into the library that happen outside of this module into that module.

therealfrauholle commented 7 months ago

While writing this I figure we can actually move most (all?) unsafe code into rust_mcd::raw, e.g. check https://github.com/veecle/tricore-probe/blob/b035ad3a51a1e6b18438929462a112c0d20c13ef/rust-mcd/src/connection.rs#L60-L62

This could be implemented as a method fn acc_hw(&self) -> &CStr for mcd_server_info_st, while ServerInfo would have a method fn acc_hw(&self) -> &str.

Just an idea how we can give this library a more consistent structure.