Symlinks break the savefile manager

Hi,

i have tried both methods in running the practice tool. unfortunately it seems that the tools doesn't start because of a path that cannot be found.

The error is the same on a fresh install on steam deck and on my fedora Linux workstation. Dark souls 3 Current Patch.

Is this a bug or am I reading the documentation wrong?

Output of debug log is here: The Directory /home/andrea/.... doesn't exist, because my user has a differerent username.

2024-08-27T12:27:33.537544Z DEBUG ThreadId(02) libds3::pointers: lib/libds3/src/pointers.rs:93: BaseAddresses {
    world_chr_man: 5443681720,
    world_chr_man_dbg: 5443681992,
    menu_man: 5443564120,
    base_a: 5443515064,
    base_d: 5443529680,
    sprj_debug_event: 5443493560,
    debug: 5443681940,
    grend: 5441506216,
    base_hbd: 5443672768,
    map_item_man: 5443588672,
    spawn_item_func_ptr: 5376852096,
    param: 5443795120,
    format_string: 5412296208,
    no_logo: 5381243887,
    current_target: 5377503338,
    menu_travel: 5381214192,
    menu_attune: 5381211417,
    xa: 8080,
    base_fps: 5443795448,
}    
2024-08-27T12:27:34.595486Z ERROR ThreadId(02) panic: /home/andrea/.cargo/registry/src/index.crates.io-6f17d22bba15001f/log-panics-2.1.0/src/lib.rs:130: thread '<unnamed>' panicked at 'internal error: entered unreachable code: Savefile path is neither file nor directory': /home/andrea/.cargo/git/checkouts/practice-tool-core-5bae16e69f761c5f/4877018/src/widgets/savefile_manager.rs:336
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: <unknown>
  15: <unknown>
  16: <unknown>
  17: <unknown>
  18: <unknown>
  19: <unknown>
  20: <unknown>
  21: <unknown>

If I can provice further assistance, I am happy to oblige at any time

Update: After setting the log level to "NONE" in the TOML the tool launches at start but I have no way to toggle functions. The "open" menu stays empty. Hotkeys (except for visible features like "open" and "hide") don't do anything. Indicators work. (see screenshots)

ds3 tool

ds3 tool_open

EDIT: After it loaded the first time, i could set the log to debug again. Weird, it could very well be my own incompetence that it didn't load the first time. Functionality unfortunately is not there yet. I already tried "reinstalling" and setting replacing the toml with an untouched version. New Output of log here

2024-08-27T14:23:09.748744Z DEBUG ThreadId(01) libjdsd_dsiii_practice_tool::practice_tool: practice-tool/src/practice_tool.rs:135: "TOML configuration parse error: Unrecognized indicator: position_change for key `settings.indicators` at line 48 column 1"
2024-08-27T14:23:14.254111Z DEBUG ThreadId(01) libds3::pointers: lib/libds3/src/pointers.rs:93: BaseAddresses {
    world_chr_man: 5443681720,
    world_chr_man_dbg: 5443681992,
    menu_man: 5443564120,
    base_a: 5443515064,
    base_d: 5443529680,
    sprj_debug_event: 5443493560,
    debug: 5443681940,
    grend: 5441506216,
    base_hbd: 5443672768,
    map_item_man: 5443588672,
    spawn_item_func_ptr: 5376852096,
    param: 5443795120,
    format_string: 5412296208,
    no_logo: 5381243887,
    current_target: 5377503338,
    menu_travel: 5381214192,
    menu_attune: 5381211417,
    xa: 8080,
    base_fps: 5443795448,
}    
2024-08-27T14:23:14.254215Z  INFO ThreadId(01) libjdsd_dsiii_practice_tool::practice_tool: practice-tool/src/practice_tool.rs:168: Initialized
2024-08-27T14:23:14.254263Z DEBUG ThreadId(01) hudhook::hooks: /home/andrea/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hudhook-0.7.0/src/hooks/mod.rs:87: WNDCLASSEXW { cbSize: 80, style: WNDCLASS_STYLES(3), cbClsExtra: 0, cbWndExtra: 0, hInstance: HINSTANCE(5368709120), hIcon: HICON(0), hCursor: HCURSOR(0), hbrBackground: HBRUSH(0), lpszMenuName: PCWSTR(0x0), lpszClassName: PCWSTR(0x6ffffca761a8), hIconSm: HICON(0) }
2024-08-27T14:23:14.270468Z DEBUG ThreadId(01) hudhook::hooks: /home/andrea/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hudhook-0.7.0/src/hooks/mod.rs:107: HWND(327862)

@derbolle first of all, I hope you haven't downloaded @c0ffincolors 's file, it is probably malicious/spam unless they care to elaborate further.

The Directory /home/andrea/.... doesn't exist, because my user has a differerent username.

That's just a reference to a path in the source code, it's not related to your system at all. Looking at the error in your first post, it sounds like the path to your Dark Souls III savefile is not a file nor a directory, which suggests something is wrong with its path. Where do you store your Wine prefix? Do you have your savefiles symlinked somewhere? I do have them but I'm not able to reproduce the error.

libjdsd_dsiii_practice_tool::practice_tool: practice-tool/src/practice_tool.rs:135: "TOML configuration parse error: Unrecognized indicator: position_change for key `settings.indicators` at line 48 column 1"

This makes me suspect there might be something wrong with the release, or you have mixed-and-matched tool version and configuration file. Could that be the case?

I cannot check myself right now, but I'll download the release and see if I can reproduce that.

Meanwhile, first try deleting all practice tool related files (the executables, the DLL, the toml and the dinput8.dll file from the game directory if you did the installation method), download the latest release and try to start over.

If that doesn't work, just delete line 48 in the .toml file for the time being, that should at least get the tool running, and if I can confirm that it's a release problem I'll release a fix soon.

No worries - The link from @c0ffincolors seemed highly sus and mediafire seemed to have immediately deleted the file. First time I am seeing obvious spam in github though.

A mix between versions (I tried the previous release before posting the issue) should be out of the question. I will try a complete "reinstall" nonetheless just to be safe.

My steam directory (also used for wine prefix in steam) is just /home/<username>/steam/steamapps/<common/compatdata>/ without symlinks etc. (on the steam deck I have a linked steamapps dir though.

I'll try your suggestion and report back

Line 48 in the toml (which I loaded from the release is [settings] - that doesn't seem right. Deleting this line does nothing to the functionality of the tool. Funny enough, if I delete the toml the tool is in the same state. Just to double check, that I am absolutely not wasting your time by making dumb mistakes:

I "Install" the Tool by extracting the dll into the Dark Souls 3 "Game" Directory.
I Rename the jdsd_dsiii_practice_tool.dll to dinput8.dll
I extract the jdsd_dsiii_practice_tool.toml and place it into the "Game" Directory
I set the Launch Options to WINEDLLOVERRIDES="dinput8=n,b" %command%
- Dark Souls III is running under Proton Experimental/Proton 9.0-2 (no difference)
- Dark Souls III is running on current patch (1.15.2) - I could try downpatching tomorrow, but would like to run and practice with current patch in the long run.
- I have been using the Save Organizer which is not running while I am trying to get this tool to work and which is not installed on my steam deck, which has a similar behaviour

Update: I tried downpatching to 1.08 Regulation 1.22 and the behaviour didn't change. (see second screenshot further up)

Update 2: It doesn't matter which version I have, under certain circumstances(like attacking some enemies like Deacons or pontiff's beast with twinblade L1 and some other "triggers") the "debug menu" opens. I'll post a screenshot from google. This happens on 1.08 and on current patch, if the Practice tool is active in any way (i currently use it for tracking igt on screen). Just if it helps you. screenshot far below under the TOML

For reference, here is my .toml from the latest release

commands = [
  { savefile_manager = "ctrl+o" },
  { item_spawner = "ctrl+u" },
  { character_stats = true },
  { cycle_speed = [0.5, 1.0, 2.0, 5.0], hotkey = "8" },
  { souls = 10000, hotkey = "9" },
  { open_menu = "travel" },
  { open_menu = "attune" },
  { group = "Positions", commands = [
    { nudge = 1.0, nudge_up = "[", nudge_down = "]" },
    { position = "h", save = "rshift+h" },
    { position = "j", save = "rshift+j" },
    { position = "k", save = "rshift+k" },
  ]},
  { group = "Render flags", commands = [
    { flag = "rend_chr", hotkey = "f4" },
    { flag = "rend_obj", hotkey = "f5" },
    { flag = "rend_map", hotkey = "f6" },
    { flag = "rend_mesh_hi", hotkey = "f7" },
    { flag = "rend_mesh_lo", hotkey = "f8" },
    # { flag = "all_draw_hit" }, # conflicts with debug_draw
    { flag = "ik_foot_ray" },
    { flag = "debug_sphere_1" },
    { flag = "debug_sphere_2" },
    { flag = "evt_draw" },
    { label = "" },
    { label = "Below needs debug draw enabled:" },
    { flag = "debug_draw" },
    { flag = "hurtbox" },
    { flag = "bloodstain_draw" },
  ]},
  { flag = "all_no_damage", hotkey = "1" },
  { flag = "inf_stamina", hotkey = "2" },
  { flag = "inf_focus", hotkey = "3" },
  { flag = "inf_consumables", hotkey = "4" },
  { flag = "deathcam", hotkey = "5" },
  { flag = "no_death", hotkey = "6" },
  { flag = "one_shot", hotkey = "7" },
  { flag = "ember", hotkey = "o" },
  { target = "ctrl+n" },
  { flag = "ai_disable", hotkey = "f1" },
  { flag = "gravity", hotkey = "f2" },
  { flag = "collision", hotkey = "f3" },
  { flag = "evt_disable", hotkey = "f9" },
  { quitout = "p" }
]

[settings]
log_level = "DEBUG"
display = "0"
hide = "rshift+0"
show_console = false
indicators = [
  { indicator = "game_version", enabled = true },
  { indicator = "igt", enabled = true },
  { indicator = "position", enabled = true },
  { indicator = "animation", enabled = true },
  { indicator = "fps", enabled = true },
  { indicator = "framecount", enabled = true },
  { indicator = "imgui_debug", enabled = false }
]

debug menu popping up sometimes: grafik

Funny enough, if I delete the toml the tool is in the same state.

That's expected. The reason is a broken configuration file, so broken or absent the end result is the same.

I set the Launch Options to WINEDLLOVERRIDES="dinput8=n,b" %command%

To clarify, are you using the right shift method (press right shift for a few seconds during startup), or are you starting the game by double clicking the executable?

Dark Souls III is running on current patch (1.15.2) - I could try downpatching tomorrow, but would like to run and practice with current patch in the long run.

There's no need to do that, the tool runs on all patches.

It doesn't matter which version I have, under certain circumstances(like attacking some enemies like Deacons or pontiff's beast with twinblade L1 and some other "triggers") the "debug menu" opens.

That's called the "dummy glitch" and it's a known game bug, that's just much worse on Linux. It's not related to the tool at all, it should go away if you change the resolution and then change it back, or close/reopen the game.

For reference, here is my .toml from the latest release

The configuration you posted doesn't include position_change in it anywhere, but the error you posted earlier clearly states:

TOML configuration parse error: Unrecognized indicator: position_change for key `settings.indicators` at line 48 column 1

This behavior is not possible without position_change being present in the TOML somewhere (specifically, under the [settings] table at line 48 column 1).

If you are indeed using the .toml from the latest release, you should not see that error message at all.

Can you please check the logs again, see if they report a different error than that?

To clarify, are you using the right shift method (press right shift for a few seconds during startup), or are you starting the game by double clicking the executable?

I am mainly using the shift + right click method but starting the exe via protontricks (as per your instructions) lead to the same behaviour.

There's no need to do that, the tool runs on all patches

That's called the "dummy glitch" and it's a known game bug, that's just much worse on Linux. It's not related to the tool at all, it should go away if you change the resolution and then change it back, or close/reopen the game.

Good to know, thanks :) - I am on current version again. If I Start the game in Window mode (1600x900) the dummy glitch doesn't happen, on 2560x1080 full screen it randomly occurs If I have loaded the practice tool. That's a non issue for me

The configuration you posted doesn't include position_change in it anywhere, but the error you posted earlier clearly states:

that's curious. I never added anything like position_change myself. I used the default and played around with various removed or changed values.

To absolutely double check, I tried again (and I tried to record it)

The UI of the tool doesn't start if the TOML is valid. as soon as I break something(e.G. comment out log_level , I have the UI but without anything i could activate(see my earlier screenshot, i just see "open")

To visualize the behaviour better, I'll try to upload a screen recording Bildschirmaufnahme_20240830_161727.webm

I am mainly using the shift + right click method

You mean right shift (i.e. the shift button on the right side of the keyboard) or shift + right click? The correct one is the former.

that's curious. I never added anything like position_change myself. I used the default and played around with various removed or changed values.

Could it be that you downloaded the .toml file from the main branch here and temporarily replaced it? That's the only way position_change might have ended up in there that I can think of. I am absolutely certain of the meaning of that specific error.

as soon as I break something(e.G. comment out log_level , I have the UI but without anything i could activate

Yes, this is a legitimate aspect of the tool that could be improved, though admittedly I haven't had many reports of that due to not many people really customizing the default.

To visualize the behaviour better, I'll try to upload a screen recording

So what happens in the video is that you don't load the savefile manager at all due to the configuration being corrupted at various times. As soon as the configuration is valid again, the tool panicks and exits because it can't determine what kind of file is your savefile.

The error points here. I was operating under the assumption that symlinks would still auto-resolve to a file or a directory, but it appears this is not the case.

Can you please make a short clip with the contents of your savefile directory (%APPDATA%/DarkSoulsIII) and its descendants? I suspect there may be some symlinks in there that break the tool.

You mean right shift (i.e. the shift button on the right side of the keyboard) or shift + right click? The correct one is the former.

Sorry, it is scorching hot here and I was a bit distracted while writing, of course I meant right shift instead of shift + right click.

Could it be that you downloaded the .toml file from the main branch here and temporarily replaced it?

my TOML file is from the current release, which I downloaded as zip from the releases page (you can see the zip file in my video)

Can you please make a short clip with the contents of your savefile directory (%APPDATA%/DarkSoulsIII) and its descendants? I suspect there may be some symlinks in there that break the tool.

I'll attach the clip here. Thanks by the way for looking into this. I really appreciate it this screenshot is from dolphin(kde file manager) which is configured to show every hidden file

grafik

here is the output of the tree command in the Appdata\roaming\darksoulsIII Directory. there seem to be no symlinks in this and child directories

[I] bolle@fedora ~ [0|1]> cd "/home/bolle/steam/steamapps/compatdata/374320/pfx/drive_c/users/steamuser/AppData/Roaming/DarkSoulsIII/"
[I] bolle@fedora ~/s/s/c/3/p/d/u/s/A/R/DarkSoulsIII> tree
.
├── 01xxxxxxxxxxx
│   ├── AnyGlitchless
│   │   ├── 01 Cemetery Start
│   │   ├── 02 - Before Gundyr
│   │   ├── 03 - After Gundyr
│   │   ├── 04 - before first shopping
│   │   ├── 05 High Wall Running Start
│   │   ├── 06 - High Wall before raw gem
│   │   ├── 07 - High Wall after Emma
│   │   ├── 08 - High Wall before Vordt
│   │   ├── 09 - After Vordt
│   │   ├── 10 - Settlement Bridge Jump 1
│   │   ├── 11 - Settlement Siegward Jump
│   │   └── 12 - Road Of Sacrifices Running Section
│   ├── AnyGlitchless1.08
│   │   ├── 01.3 - highwall jump
│   │   ├── 01.5 - Settlement Thrall Gauntlet
│   │   ├── 01.6 - Crux woods before grass crest
│   │   ├── 01.7 - Farron entrance
│   │   ├── 01.8 - Farron Second fire
│   │   ├── 01.9 - Farron before run to watchers
│   │   ├── 01 -Cemetery Start
│   │   ├── 02 Before Watchers
│   │   ├── 03 - After Watchers
│   │   ├── 04 - Before Wolnir
│   │   ├── 05 - After Wolnir - sell souls, buy 4 rouge 3 bones, 30 dex
│   │   ├── 06 - before sage (nicht optimal)
│   │   ├── 07 - after sage
│   │   ├── 08 - Running section Cathedral Start
│   │   ├── 09 - Cathedral door
│   │   ├── 10 - before Deacons
│   │   ├── 11 - after deacons
│   │   ├── 12 - Irithyll before Doggo
│   │   ├── 13 - Irithyll Start Bonfire - weight below 30%!
│   │   ├── 14 - Irithyll Distant Manor. Start Path to yhorm
│   │   ├── 15 - Irithyll Dungeon skip
│   │   ├── 16 - Irithyll Yhorm run up
│   │   ├── 17 - Irithyll before Yhorm (nicht optimal)
│   │   ├── 18 - Irithyll after Yhorm
│   │   ├── 19 - Irithyll vor Pontiff running section. Herald Set (keine rüstung + Ass gloves + Skulls)
│   │   ├── 20 - Vor Pontiff
│   │   ├── 21 - after Pontiff
│   │   ├── 22 - FIrelink vor Aldrich
│   │   ├── 23 - before aldrich jump
│   │   ├── 24 - before aldrich fog
│   │   ├── 25 - before dancer (nicht optimal)
│   │   ├── 26 - after dancer
│   │   ├── 26 - Lothric Castle Start
│   │   ├── 27 - lothric castle fall damage cancel
│   │   ├── 28 - DSA Menuing practice
│   │   ├── 29 - DSA Practice
│   │   └── 30 - after DSA
│   ├── AnyGlitchlessCurrentNewRoute
│   │   ├── 00 - Start Cemetery
│   │   ├── 01 - Before Gundyr
│   │   ├── 02 - After Gundyr
│   │   ├── 03.5 - Highwall Balcony Jump
│   │   ├── 03 - Start Highwall
│   │   ├── 04 - Before Vordt
│   │   ├── 05 - After Vordt
│   │   ├── 06 - After Sharp Gem
│   │   ├── 07 - Start Road of Sacrifice
│   │   ├── 08 - Road Of Sacrifice Runthrough Start
│   │   ├── 09 - Road of Sacrifices before BlackKnight
│   │   ├── 10 - Farron Swamp start
│   │   ├── 11 - Farron swamp second fire lit
│   │   ├── 12 FIrelink +3 sword 13 vig 16 dex
│   │   ├── 13 Run to watchers
│   │   ├── 14 - before Watchers
│   │   ├── 15 - After Watchers
│   │   ├── 16 - before Wolnir
│   │   └── 17 - Firelink shopping - 4 rouge, 3 bones,30 dex
│   ├── DS30000.sl2
│   └── DS3 runthrough - backupsaves
│       └── DS30000.sl2
├── GraphicsConfig.xml
└── steam_autocloud.vdf

6 directories, 72 files

A few directories up (/home/bolle/steam/steamapps/compatdata/374320/pfx/drive_c/users/steamuser) there are a few symlinks, which could be used to reference the directories in question (e.g. application data --> appadata) - I don't think that this is likely though.

grafik

can I try anything else for you or provide you with any further assistance?

Apologies for the delays, I've been pretty busy lately. Honestly, all of it looks good to me. As soon as I can, I'll try and make a nightly build to improve error reporting so we can pinpoint where exactly is the problem in the directory structure. Keep an eye on this thread, I'll add a comment with instructions.

@derbolle I have uploaded a release with more observability here, please give it a try when you can and report what error you get!

Hi,

thanks for your patience. I don't exactly know what you changed but it did the trick. I could use the practice tool from your nightly release without issue on linux and trigger effects (e.g. Ember and inf. stamina, in a second session no death, inf consumables, target entity info etc.). If you need any further testing, I am happy to try different things. Otherwise I will use the nightly build (until the next release) for my practicing purposes for now.

2024-09-15T11:16:26.906920Z DEBUG ThreadId(01) libds3::pointers: lib/libds3/src/pointers.rs:93: BaseAddresses {
    world_chr_man: 5443681720,
    world_chr_man_dbg: 5443681992,
    menu_man: 5443564120,
    base_a: 5443515064,
    base_d: 5443529680,
    sprj_debug_event: 5443493560,
    debug: 5443681940,
    grend: 5441506216,
    base_hbd: 5443672768,
    map_item_man: 5443588672,
    spawn_item_func_ptr: 5376852096,
    param: 5443795120,
    format_string: 5412296208,
    no_logo: 5381243887,
    current_target: 5377503338,
    menu_travel: 5381214192,
    menu_attune: 5381211417,
    xa: 8080,
    base_fps: 5443795448,
}    
2024-09-15T11:16:26.913025Z  INFO ThreadId(01) libjdsd_dsiii_practice_tool::practice_tool: practice-tool/src/practice_tool.rs:171: Initialized
2024-09-15T11:16:26.913087Z DEBUG ThreadId(01) hudhook::hooks: /home/andrea/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hudhook-0.7.1/src/hooks/mod.rs:87: WNDCLASSEXW { cbSize: 80, style: WNDCLASS_STYLES(3), cbClsExtra: 0, cbWndExtra: 0, hInstance: HINSTANCE(5368709120), hIcon: HICON(0), hCursor: HCURSOR(0), hbrBackground: HBRUSH(0), lpszMenuName: PCWSTR(0x0), lpszClassName: PCWSTR(0x6ffffca601b8), hIconSm: HICON(0) }
2024-09-15T11:16:26.931088Z DEBUG ThreadId(01) hudhook::hooks: /home/andrea/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hudhook-0.7.1/src/hooks/mod.rs:107: HWND(65716)
2024-09-15T11:16:50.107622Z  INFO ThreadId(02) libjdsd_dsiii_practice_tool::practice_tool: practice-tool/src/practice_tool.rs:616: Ember deactivated
2024-09-15T11:16:51.574751Z  INFO ThreadId(02) libjdsd_dsiii_practice_tool::practice_tool: practice-tool/src/practice_tool.rs:616: Ember activated
2024-09-15T11:16:52.507870Z  INFO ThreadId(02) libjdsd_dsiii_practice_tool::practice_tool: practice-tool/src/practice_tool.rs:616: Ember deactivated
2024-09-15T11:16:53.274429Z  INFO ThreadId(02) libjdsd_dsiii_practice_tool::practice_tool: practice-tool/src/practice_tool.rs:616: Ember activated
2024-09-15T11:16:57.625120Z  INFO ThreadId(02) libjdsd_dsiii_practice_tool::practice_tool: practice-tool/src/practice_tool.rs:616: Inf Stamina activated
2024-09-15T11:17:09.161567Z  INFO ThreadId(02) libjdsd_dsiii_practice_tool::practice_tool: practice-tool/src/practice_tool.rs:616: Inf Stamina deactivated
2024-09-15T11:17:14.708856Z  INFO ThreadId(02) libjdsd_dsiii_practice_tool::practice_tool: practice-tool/src/practice_tool.rs:616: Quitout triggered

Interesting. Can you try again with the stable release? Could you please also try opening/using the savefile manager, see if more errors pop up? Thank you!

veeenu / darksoulsiii-practice-tool

Symlinks break the savefile manager #82