Let minhook be a Git submodule

veeenu / hudhook

A videogame overlay framework written in Rust, supporting DirectX and OpenGL

MIT License

167 stars 27 forks source link

Let minhook be a Git submodule #179

Closed sylvavv closed 3 months ago

sylvavv commented 3 months ago

Maybe this way would be better?

sylvavv commented 3 months ago

The suggested method is not suitable. If the person's computer does not have git, then it is not possible to compile hudhook.

veeenu commented 3 months ago

The existence of git is not a big deal -- it's a reasonable dependency not to mention some parts of cargo itself rely on it. But I still think vendoring the code is a better idea: a submodule means relying on an external data source that's outside of our control, and that disadvantage is not offset by any equal or superior advantage to us, especially considering how small and self contained minhook is.