Closed ruby3141 closed 5 months ago
Thank you for your contribution! 🙏 Please allow me a bit of time to thoroughly review this, but I like what I've seen so far.
In addition to your change requests, I made MessageFilter::is_blocking()
pub(crate)
,
because it would not be used in user code.
Test for only MessageFilter::WindowControl
is added to the test hook, because harness itself doesn't seems to handle any input.
The font is NeoDunggeunmo Code. It's one of a few programming fonts that natively supports korean glyphs, and because of its bitmap appearance and square sizing it matches very well with unifont fallback.
This PR introduces BREANKING changes described below;
MessageFilter::all()
onset_message_filter()
.This PR fixes #182.