search

veekun / pokedex

more than you ever wanted to know about Pokémon
MIT License
1.45k stars 636 forks source link

Split tables.py into several files #139

Open encukou opened 9 years ago

encukou commented 9 years ago

This splits off the Conquest tables into their own file. Sanky's planned maps can also go into their own file.

thechief389 commented 6 years ago

This pull requests violates part of PEP 423 (the db package has another package inside it)

magical commented 6 years ago

@thechief389 1) PEP 423 is a guideline, not a rule 2) The PEP status is Deferred, not Accepted 3) pokedex has never been a model of good code organization imo 4) this PR is over three years old

encukou commented 6 years ago

I also don't think PEP 423 is relevant. It is very far from being a collection of accepted best practices. Also, I believe both reasons it gives for "Flat is better than nested" don't really apply in this case.

That said, I don't think this PR is useful. It has bit-rotted, and in case a a new category of tables needs to be added, recreating it might actually be easier than rebasing.

Feel free to re-open if you disagree.

magical commented 6 years ago

@encukou I think it's still worth doing. Would you mind opening an issue?

encukou commented 6 years ago

Ah, OK. Then it's probably better as a PR, with a code example.

thechief389 commented 6 years ago

This PR is three years old because nobody is here to work on this project. The only way to solve this problem is if there were more people working on it.

magical commented 6 years ago

Granted. It's one of my continuing sources of sadness that i don't have more time to contribute to veekun.