search

veekun / pokedex

more than you ever wanted to know about Pokémon
MIT License
1.44k stars 637 forks source link

[refactoring] Consider removing non main-series data #233

Open route1rodent opened 6 years ago

route1rodent commented 6 years ago

This project contains basically main RPG series data, with some exceptions like all tables and columns related to the Conquest games, including all the abilities withid higher than 10000 and the abilities.is_main_series column.

For consistency with the rest of the project, I suggest stop supporting that data and remove it.

There is also other data that is part of the main series but it is not common in the core mechanics of all games: pokeathlon, palpark and contests, ... but I think it's not so bad to keep it.

magical commented 6 years ago

I'd be sad to see conquest removed entirely, as we're one of the few sources of data on it.

I do think we should disentangle conquest from the main db—give it its own tables for abilities, moves, and pokemon, etc. I believe Zhorken has expressed regret that she didn't do that in the first place.

route1rodent commented 6 years ago

to separate it would be another option yeah