search

veekun / pokedex

more than you ever wanted to know about Pokémon
MIT License
1.44k stars 637 forks source link

Added basic descriptions for missing items. #234

Open slawekwaga opened 6 years ago

slawekwaga commented 6 years ago

Added missing descriptions. They are really basic

magical commented 6 years ago

You've added a bunch of empty columns to the CSV files, which isn't gonna work.

slawekwaga commented 6 years ago

Oops. Used LibreOffice to edit these files.

slawekwaga commented 6 years ago

The change on Gale wings and Parental bond occured in gen VII

magical commented 6 years ago

We should probably add a changelog entry, then: https://github.com/veekun/pokedex/blob/master/pokedex/data/csv/ability_changelog.csv https://github.com/veekun/pokedex/blob/master/pokedex/data/csv/ability_changelog_prose.csv

slawekwaga commented 6 years ago

There's a lot of changes on abilities and moves. More on that subject here: https://pokemondb.net/pokebase/270531/what-are-all-the-nerfs-and-buffs-in-pokemon-sun-and-moon

slawekwaga commented 6 years ago

And some Items changed as well. Super Potion, Hyper Potion, Rage Candy Bar

magical commented 6 years ago

Ah, thanks for the link. I only mentioned Parental Bond and Gale Wings because those seem to be the only two abilities updated in the PR.

The other changes look good. I'm happy to merge the PR if you add changelog entries for Parental Bond and Gale Wings. You could also revert those two changes and open a new PR for them. (And if you wanted to update some of the other moves and abilities that would be fine too 😁 )