search

veekun / pokedex

more than you ever wanted to know about Pokémon
MIT License
1.44k stars 637 forks source link

Added distance flag to gear up #235

Closed Unknown008 closed 5 years ago

Unknown008 commented 6 years ago

I'm not sure why it wasn't flagged as distance. It's similar to Aromatherapy or Heal Bell in terms of targeting to me, so I'd flag Gear Up as distance too.

magical commented 6 years ago

Huh, Generally the move flags are ripped straight from the games' data, so either there is a bug in the ripper (which is quite possible – it happens), or the data we have is in fact correct. I can't tell from your commit message whether you have hard evidence that we are wrong, or just a feeling. Could you clarify?

Unknown008 commented 6 years ago

Ah, no, I don't have any hard evidence. It's just a feeling because Gear Up could be said to work in the same way as Aromatherapy and Heal Bell (they affect all users on the user's side of the field including themselves). I just find it odd that Gear Up does not have this flag as well.

Sorry for not being clear enough. Should I make a pull request next time, I'll elaborate more. I'm not very familiar with how it works ^^;

magical commented 5 years ago

Let's leave this one alone. Serebii doesn't flag Gear Up as being able to hit the opposite side it triple battles either. https://www.serebii.net/attackdex-sm/gearup.shtml

I see what you mean though. It does seem inconsistent. My guess is that moves like Aromatherapy and Gear Up that target the entire party ignore this flag altogether, so its value is meaningless to the game.