search

veekun / pokedex

more than you ever wanted to know about Pokémon
MIT License
1.44k stars 637 forks source link

Record gift pokemon #238

Closed jrubinator closed 5 years ago

jrubinator commented 6 years ago

This is a pretty naïve approach to adding gift pokemon, but there are relatively few of them.

This list is compiled from https://bulbapedia.bulbagarden.net/wiki/Gift_Pokémon and the google spreadsheet linked from #3

magical commented 5 years ago

Nice. I'll have to take a closer look at this sometime.

magical commented 5 years ago

https://bulbapedia.bulbagarden.net/wiki/List_of_locations_by_index_number_(Generation_VI)

magical commented 5 years ago

I added the Battle Resort and other missing OR/AS locations in https://github.com/veekun/pokedex/commit/f2d03da17788006dc9a91292d87a14360b978cc0. Could you update this PR to use the new locations?

jrubinator commented 5 years ago

Will do, it might be a couple of days before I can get to it though.

magical commented 5 years ago

No problem. Sorry it took so long to review.

jrubinator commented 5 years ago

It looks like the failures here are caused by 6d4d129c84cfcfebee6785c199b1ea2a49bf7a73

@magical - it looks like that's already on master. I don't see any issues for it yet; would you like me to file one?

magical commented 5 years ago

@jrubinator Yeah, i know. Sorry about that. I have a fix pending, just tweaking some wording -- probably no need to open an issue.

magical commented 5 years ago

Okay, should be fixed now.

encukou commented 5 years ago

As I see it, you get an item at the first location. Then elsewhere you get a pokémon in exchange for the item, similarly to how you pay for the “gift” Magikarp.

magical commented 5 years ago

Right. If we had a table for item locations then fossils would obviously belong there. (We don't though.)

magical commented 5 years ago

@jrubinator I added some commits to remove fossil pokémon (for now) and set the slot rarity. We can figure out what to do about fossil pokémon later. I'm planning to merge this soon unless you have any objections.

DaanVandenBosch commented 5 years ago

Is there a reason this hasn't been merged yet?

magical commented 5 years ago

@DaanVandenBosch Mostly a lack of time. I'm hoping to pick this up again this summer.