added pokedexes for Sun/Moon and Ultrasun/Ultramoon

veekun / pokedex

more than you ever wanted to know about Pokémon

MIT License

1.44k stars 637 forks source link

Closed nitwhiz closed 5 years ago

nitwhiz commented 5 years ago

for #217 used bulbapedia as source, alolan forms are used instead of their normal forms in species_id

magical commented 5 years ago

alolan forms are used instead of their normal forms in species_id

It doesn't work like that. species_id has to point to a row in the pokemon_species table, which only contains species, not forms.

Doesn't Alola have four separate dexes?

magical commented 5 years ago

We can't merge this unless the species_ids are fixed. Closing.

magical commented 5 years ago

Oh, i just noticed that codedmonkey submitted an alternative PR, https://github.com/veekun/pokedex/pull/269. I'll probably end up merging that one.