search

veekun / pokedex

more than you ever wanted to know about Pokémon
MIT License
1.44k stars 637 forks source link

Generation VII's name doesn't follow standard of other Generation names #251

Closed SethETaron closed 5 years ago

SethETaron commented 5 years ago

Generation VII's name is "sun-moon", but all other generation names are named like "generation-i", "generation-ii", etc. It should be changed to conform to this standard.

magical commented 5 years ago

Oh weird, you're right. @eevee, was this intentional?

SethETaron commented 5 years ago

If it turns out to not be intentional, I created an MR with modifications for this issue and also 250 and 252 :)

eevee commented 5 years ago

I have no idea why I did this! Probably hit up-enter a little too eagerly after adding the version group.

SethETaron commented 5 years ago

Makes perfect sense! I added the change in PR #253 :)