search

veekun / pokedex

more than you ever wanted to know about Pokémon
MIT License
1.44k stars 637 forks source link

pokedex dump -l doesn't work as documented #295

Open magical opened 4 years ago

magical commented 4 years ago

The help text for pokedex dump -l says

  -l LANGS, --langs LANGS
                        comma-separated list of language codes to load,
                        'none', or 'all' (default: en)

However, the values 'none' and 'all' don't work (they are treated as language names) and the default is to dump all languages, not just English.

We should either make it work the way it says it does or fix the documentation.

rluzuriaga commented 4 years ago

My pull request keeps the same default functionality just adds more checks and functionality for 'none' and 'all'. As well as changed the documentation. I thought that changing the default to actually be English would more than likely break other projects that depend on this repo.